From: Kexin Sun Date: Tue, 24 Mar 2026 04:14:00 +0000 (+0800) Subject: ASoC: update outdated comments for removed snd_soc_new_pcms() X-Git-Tag: v7.1-rc1~166^2~5^2~68 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e839947b842b81e3d940044425853477c5a4d7e;p=thirdparty%2Flinux.git ASoC: update outdated comments for removed snd_soc_new_pcms() The function snd_soc_new_pcms() was removed during the multi-component refactoring in commit f0fba2ad1b6b ("ASoC: multi-component - ASoC Multi-Component Support"). Its PCM creation role is now handled by soc_new_pcm(), which was later moved to sound/soc/soc-pcm.c by commit ddee627cf6bb ("ASoC: core - Separate out PCM operations into new file."). In fsl_dma.c, update the comment to reference soc_new_pcm(). Also remove the stale paragraph about snd_dma_alloc_pages() always allocating in lowmem, since commit e159704f7920 ("ASoC: fsl_dma: Use managed buffer allocation") replaced that call with snd_pcm_set_fixed_buffer_all(). In siu_pcm.c, remove the stale comment referencing snd_soc_new_pcms() and the no-longer-existing socdev structure. Assisted-by: unnamed:deepseek-v3.2 coccinelle Signed-off-by: Kexin Sun Link: https://patch.msgid.link/20260324041400.16217-1-kexinsun@smail.nju.edu.cn Signed-off-by: Mark Brown --- diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index b120b3514fbec..b124748801850 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -267,14 +267,8 @@ static irqreturn_t fsl_dma_isr(int irq, void *dev_id) /** * fsl_dma_new: initialize this PCM driver. * - * This function is called when the codec driver calls snd_soc_new_pcms(), - * once for each .dai_link in the machine driver's snd_soc_card - * structure. - * - * snd_dma_alloc_pages() is just a front-end to dma_alloc_coherent(), which - * (currently) always allocates the DMA buffer in lowmem, even if GFP_HIGHMEM - * is specified. Therefore, any DMA buffers we allocate will always be in low - * memory, but we support for 36-bit physical addresses anyway. + * This function is called by soc_new_pcm(), once for each DAI link + * in the machine driver's snd_soc_card structure. * * Regardless of where the memory is actually allocated, since the device can * technically DMA to any 36-bit address, we do need to set the DMA mask to 36. diff --git a/sound/soc/renesas/siu_pcm.c b/sound/soc/renesas/siu_pcm.c index ae5c0c40299d6..fd5b20b469a4a 100644 --- a/sound/soc/renesas/siu_pcm.c +++ b/sound/soc/renesas/siu_pcm.c @@ -483,7 +483,6 @@ siu_pcm_pointer_dma(struct snd_soc_component *component, static int siu_pcm_new(struct snd_soc_component *component, struct snd_soc_pcm_runtime *rtd) { - /* card->dev == socdev->dev, see snd_soc_new_pcms() */ struct snd_card *card = rtd->card->snd_card; struct snd_pcm *pcm = rtd->pcm; struct siu_info *info = siu_i2s_data;