From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Mon, 6 Sep 2021 22:24:36 +0000 (-0500)
Subject: LGTM is stupid and says we don't return a value in all code paths.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e960a2af7e79ddb506d03f5758f6060998d4d24;p=thirdparty%2Ffreeradius-server.git

LGTM is stupid and says we don't return a value in all code paths.
---

diff --git a/src/lib/eap_aka_sim/base.c b/src/lib/eap_aka_sim/base.c
index 03c4185398d..a0f5079efc3 100644
--- a/src/lib/eap_aka_sim/base.c
+++ b/src/lib/eap_aka_sim/base.c
@@ -232,12 +232,14 @@ size_t fr_aka_sim_attr_len(fr_pair_t const *vp)
 	case FR_TYPE_VARIABLE_SIZE:
 		return vp->vp_length;
 
-	default:
-		return fr_aka_sim_attr_sizes[vp->vp_type][0];
-
 	case FR_TYPE_STRUCTURAL:
 		if (!fr_cond_assert(0)) return 0;
+
+	default:
+		break;
 	}
+
+	return fr_aka_sim_attr_sizes[vp->vp_type][0];
 }
 
 /** Return the number of bytes before the octets value