From: Volker Lendecke <vl@samba.org>
Date: Sun, 25 Jul 2021 07:51:10 +0000 (+0200)
Subject: net3: Simplify name_to_sid(): dom_sid_parse checks for "S-" prefix
X-Git-Tag: ldb-2.5.0~1014
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3eaa2bcb89d310ce80137226c86bc2a5d8ea586c;p=thirdparty%2Fsamba.git

net3: Simplify name_to_sid(): dom_sid_parse checks for "S-" prefix

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/utils/net_rpc_rights.c b/source3/utils/net_rpc_rights.c
index 97844882fda..d4cc5eabbe3 100644
--- a/source3/utils/net_rpc_rights.c
+++ b/source3/utils/net_rpc_rights.c
@@ -73,7 +73,7 @@ static NTSTATUS name_to_sid(struct rpc_pipe_client *pipe_hnd,
 	struct dcerpc_binding_handle *b = pipe_hnd->binding_handle;
 
 	/* maybe its a raw SID */
-	if ( strncmp(name, "S-", 2) == 0 && string_to_sid(sid, name) ) {
+	if (dom_sid_parse(name, sid)) {
 		return NT_STATUS_OK;
 	}