From: Daniel Salzman <daniel.salzman@nic.cz>
Date: Wed, 26 Aug 2020 12:19:10 +0000 (+0200)
Subject: backup: tiny code improvements (Coverity)
X-Git-Tag: v3.0.0~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ee38e67ff934fbcdb87161aaa4e2f433a7a104a;p=thirdparty%2Fknot-dns.git

backup: tiny code improvements (Coverity)
---

diff --git a/src/knot/conf/conf.c b/src/knot/conf/conf.c
index af2597b560..0ebeda51c7 100644
--- a/src/knot/conf/conf.c
+++ b/src/knot/conf/conf.c
@@ -837,6 +837,10 @@ conf_mod_id_t* conf_mod_id(
 void conf_free_mod_id(
 	conf_mod_id_t *mod_id)
 {
+	if (mod_id == NULL) {
+		return;
+	}
+
 	free(mod_id->name);
 	free(mod_id->data);
 	free(mod_id);
diff --git a/src/knot/zone/backup.c b/src/knot/zone/backup.c
index 3f1480293b..9b1f150a9a 100644
--- a/src/knot/zone/backup.c
+++ b/src/knot/zone/backup.c
@@ -182,7 +182,7 @@ static int backup_keystore(conf_t *conf, zone_t *zone, zone_backup_ctx_t *ctx)
 	}
 
 	char kasp_dir[strlen(ctx->backup_dir) + 6];
-	snprintf(kasp_dir, sizeof(kasp_dir), "%s/keys", ctx->backup_dir);
+	(void)snprintf(kasp_dir, sizeof(kasp_dir), "%s/keys", ctx->backup_dir);
 	ret = keystore_load("keys", KEYSTORE_BACKEND_PEM, kasp_dir, &to);
 	if (ret != KNOT_EOK) {
 		goto done;