From: Ralph Boehme Date: Fri, 28 Jan 2022 16:51:10 +0000 (+0100) Subject: s3/libads: ensure a sockaddr variable is correctly zero initialized X-Git-Tag: tevent-0.12.0~758 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ee690455eb963dedc7955b79316481387d4ac8c;p=thirdparty%2Fsamba.git s3/libads: ensure a sockaddr variable is correctly zero initialized is_zero_addr() doesn't work with addresses that have been zero-initialized. This fixes the logic added in c863cc2ba34025731a18ac735f714b5b888504da. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14674 MR: https://gitlab.com/samba-team/samba/-/merge_requests/2354 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Feb 8 20:24:12 UTC 2022 on sn-devel-184 --- diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c index 28f396f0fe4..647cdbd0459 100755 --- a/source3/libads/ldap.c +++ b/source3/libads/ldap.c @@ -605,7 +605,9 @@ ADS_STATUS ads_connect(ADS_STRUCT *ads) ADS_STATUS status; NTSTATUS ntstatus; char addr[INET6_ADDRSTRLEN]; - struct sockaddr_storage existing_ss = {0}; + struct sockaddr_storage existing_ss; + + zero_sockaddr(&existing_ss); /* * ads_connect can be passed in a reused ADS_STRUCT