From: Mark Andrews Date: Mon, 18 Jul 2022 07:34:30 +0000 (+1000) Subject: Remove dead code X-Git-Tag: v9.19.5~13^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ef734e0f5611290fd334cd3cacee1972886776f;p=thirdparty%2Fbind9.git Remove dead code *** CID 352812: Control flow issues (DEADCODE) /lib/ns/query.c: 8584 in query_filter64() 8578 cleanup: 8579 if (buffer != NULL) { 8580 isc_buffer_free(&buffer); 8581 } 8582 8583 if (myrdata != NULL) { >>> CID 352812: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "dns_message_puttemprdata(cl...". 8584 dns_message_puttemprdata(client->message, &myrdata); 8585 } 8586 8587 if (myrdataset != NULL) { 8588 dns_message_puttemprdataset(client->message, &myrdataset); 8589 } --- diff --git a/lib/ns/query.c b/lib/ns/query.c index d1c969ca161..ea676dd537e 100644 --- a/lib/ns/query.c +++ b/lib/ns/query.c @@ -8462,10 +8462,6 @@ cleanup: isc_buffer_free(&buffer); } - if (myrdata != NULL) { - dns_message_puttemprdata(client->message, &myrdata); - } - if (myrdataset != NULL) { dns_message_puttemprdataset(client->message, &myrdataset); } @@ -8480,6 +8476,7 @@ cleanup: } dns_message_puttemprdatalist(client->message, &myrdatalist); } + if (qctx->dbuf != NULL) { ns_client_releasename(client, &name); }