From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 24 Aug 2023 22:53:00 +0000 (+1200)
Subject: tests/krb5: Correctly assert that we found a LOGON_INFO PAC buffer
X-Git-Tag: tevent-0.16.0~759
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f01cf9169947d52138a16c53d5bedb28f8c78cc;p=thirdparty%2Fsamba.git

tests/krb5: Correctly assert that we found a LOGON_INFO PAC buffer

Because ‘found_logon_info’ was invariably true, we would miss the case
in which set_pac_sids() failed to accomplish anything, having been
unable to find the LOGON_INFO PAC buffer.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py
index e2eea210073..87de2fd5032 100644
--- a/python/samba/tests/krb5/kdc_base_test.py
+++ b/python/samba/tests/krb5/kdc_base_test.py
@@ -1603,7 +1603,7 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest):
             else:
                 self.fail(f'invalid SID type {sid_type}')
 
-        found_logon_info = True
+        found_logon_info = False
 
         pac_buffers = pac.buffers
         for pac_buffer in pac_buffers: