From: Volker Lendecke <vl@samba.org>
Date: Thu, 23 Oct 2008 13:43:36 +0000 (+0200)
Subject: Optimize x_fread to speed up the smbclient put command
X-Git-Tag: samba-4.0.0alpha6~721^2^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f0406f609899e88f15f90688c0e49beadc72568;p=thirdparty%2Fsamba.git

Optimize x_fread to speed up the smbclient put command
---

diff --git a/lib/util/xfile.c b/lib/util/xfile.c
index 94b0ee9b189..cf195706db0 100644
--- a/lib/util/xfile.c
+++ b/lib/util/xfile.c
@@ -329,12 +329,27 @@ int x_fgetc(XFILE *f)
 /** simulate fread */
 size_t x_fread(void *p, size_t size, size_t nmemb, XFILE *f)
 {
+	size_t remaining = size * nmemb;
 	size_t total = 0;
-	while (total < size*nmemb) {
-		int c = x_fgetc(f);
-		if (c == EOF) break;
-		(total+(char *)p)[0] = (char)c;
-		total++;
+
+	while (remaining > 0) {
+		size_t thistime;
+
+		x_fillbuf(f);
+
+		if (f->bufused == 0) {
+			f->flags |= X_FLAG_EOF;
+			break;
+		}
+
+		thistime = MIN(f->bufused, remaining);
+
+		memcpy((char *)p+total, f->next, thistime);
+
+		f->next += thistime;
+		f->bufused -= thistime;
+		remaining -= thistime;
+		total += thistime;
 	}
 	return total/size;
 }