From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Fri, 15 Feb 2019 21:22:20 +0000 (+0100)
Subject: recuweb: remove api-key from interface, can just use basic auth
X-Git-Tag: dnsdist-1.4.0-beta1~17^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f07f0ce65c41862b97f0a1e347a4452572c9cbb;p=thirdparty%2Fpdns.git

recuweb: remove api-key from interface, can just use basic auth
---

diff --git a/pdns/recursordist/html/index.html b/pdns/recursordist/html/index.html
index c913094e46..2624b90fa5 100644
--- a/pdns/recursordist/html/index.html
+++ b/pdns/recursordist/html/index.html
@@ -22,9 +22,7 @@
 <!-- ========================= CONTENT ========================= -->
 
 <div class="topbar">
-    <label>API Key: <input type="password" id="password" value=""></label>
-    <button>Submit</button><!-- Just a trick to make the user click outside of the input field -->
-    <span id="connection-status" style="display:none">No server connection or incorrect key</span>
+    <span id="connection-status" style="display:none">No server connection</span>
     <span id="connection-error"></span>
 </div>
 
diff --git a/pdns/recursordist/html/local.js b/pdns/recursordist/html/local.js
index 9e6fc03190..549102c0e2 100644
--- a/pdns/recursordist/html/local.js
+++ b/pdns/recursordist/html/local.js
@@ -21,12 +21,6 @@ $(document).ready(function () {
         $('#' + name).html(h);
     };
 
-    var password = $("#password").val();
-    $("#password").change(function (e) {
-        password = $("#password").val();
-        update();
-    });
-
     var qpsgraph = new Rickshaw.Graph({
         element: document.getElementById("qpschart"),
         width: 400,
@@ -70,7 +64,6 @@ $(document).ready(function () {
 
     var jsonstatParams = function (command, name, filtered) {
         var d = {
-            'api-key': password,
             'command': command,
             'name': name
         };
@@ -159,7 +152,7 @@ $(document).ready(function () {
 
     function update() {
         $.ajax({
-            url: 'api/v1/servers/localhost/statistics?api-key=' + password,
+            url: 'api/v1/servers/localhost/statistics',
             type: 'GET',
             dataType: 'json',
             success: function (adata, x, y) {
@@ -216,7 +209,7 @@ $(document).ready(function () {
 
         if (!version) {
             $.ajax({
-                url: 'api/v1/servers/localhost?api-key=' + password, type: 'GET', dataType: 'json',
+                url: 'api/v1/servers/localhost', type: 'GET', dataType: 'json',
                 success: function (data) {
                     version = "PowerDNS " + data["daemon_type"] + " " + data["version"];
                 }