From: Philippe Antoine <contact@catenacyber.fr>
Date: Thu, 19 Nov 2020 13:28:43 +0000 (+0100)
Subject: dnp3: fix signed integer overflow
X-Git-Tag: suricata-5.0.5~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f087323203ebf270c20ff923d4a24ac137da63c;p=thirdparty%2Fsuricata.git

dnp3: fix signed integer overflow

By using unsigned integers everywhere
---

diff --git a/scripts/dnp3-gen/dnp3-gen.py b/scripts/dnp3-gen/dnp3-gen.py
index 0396b6d5c6..c5f2ce5668 100755
--- a/scripts/dnp3-gen/dnp3-gen.py
+++ b/scripts/dnp3-gen/dnp3-gen.py
@@ -359,15 +359,15 @@ static int DNP3DecodeObjectG{{object.group}}V{{object.variation}}(const uint8_t
     DNP3PointList *points)
 {
     DNP3ObjectG{{object.group}}V{{object.variation}} *object = NULL;
-    int bytes = (count / 8) + 1;
+    uint32_t bytes = (count / 8) + 1;
     uint32_t prefix = 0;
-    int point_index = start;
+    uint32_t point_index = start;
 
     if (!DNP3ReadPrefix(buf, len, prefix_code, &prefix)) {
         goto error;
     }
 
-    for (int i = 0; i < bytes; i++) {
+    for (uint32_t i = 0; i < bytes; i++) {
 
         uint8_t octet;