From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 7 Jul 2023 14:44:34 +0000 (-0400)
Subject: handler->identity can be const
X-Git-Tag: release_3_2_4~211
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f1c4dadbb576981db1aca3fd7a1d96fc6489a59;p=thirdparty%2Ffreeradius-server.git

handler->identity can be const

and it's already parented from handler, so we don't need to
explicitly free it
---

diff --git a/src/modules/rlm_eap/eap.h b/src/modules/rlm_eap/eap.h
index b487c086508..849d1c6d689 100644
--- a/src/modules/rlm_eap/eap.h
+++ b/src/modules/rlm_eap/eap.h
@@ -103,7 +103,7 @@ typedef struct _eap_handler {
 
 	REQUEST		*request;
 
-	char		*identity;	//!< User name from EAP-Identity
+	char const     	*identity;	//!< User name from EAP-Identity
 
 	EAP_DS 		*prev_eapds;
 	EAP_DS 		*eap_ds;
diff --git a/src/modules/rlm_eap/mem.c b/src/modules/rlm_eap/mem.c
index 988b28474bc..270721bc72e 100644
--- a/src/modules/rlm_eap/mem.c
+++ b/src/modules/rlm_eap/mem.c
@@ -78,11 +78,6 @@ void eap_ds_free(EAP_DS **eap_ds_p)
 
 static int _eap_handler_free(eap_handler_t *handler)
 {
-	if (handler->identity) {
-		talloc_free(handler->identity);
-		handler->identity = NULL;
-	}
-
 	if (handler->prev_eapds) eap_ds_free(&(handler->prev_eapds));
 	if (handler->eap_ds) eap_ds_free(&(handler->eap_ds));