From: Byron Jones <glob@glob.com.au>
Date: Tue, 2 Nov 2010 23:18:33 +0000 (+0100)
Subject: Bug 600464: (CVE-2010-3172) [SECURITY] Content/Header injection due to non-random... 
X-Git-Tag: bugzilla-4.1.1~163
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b;p=thirdparty%2Fbugzilla.git

Bug 600464: (CVE-2010-3172) [SECURITY] Content/Header injection due to non-random multipart/x-mixed-replace boundary
r=mkanat a=LpSolit
---

diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index a9b938c6d7..8ec3ac28e8 100644
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -213,7 +213,8 @@ sub multipart_init {
     }
 
     # Set the MIME boundary and content-type
-    my $boundary = $param{'-boundary'} || '------- =_aaaaaaaaaa0';
+    my $boundary = $param{'-boundary'}
+        || '------- =_' . generate_random_password(16);
     delete $param{'-boundary'};
     $self->{'separator'} = "\r\n--$boundary\r\n";
     $self->{'final_separator'} = "\r\n--$boundary--\r\n";