From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 30 May 2017 13:14:30 +0000 (-0400)
Subject: don't do double unlock
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f3fb726af323b09182de9f3c401a67336350be3;p=thirdparty%2Ffreeradius-server.git

don't do double unlock

CID #1020958
---

diff --git a/src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c b/src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c
index 7c6de4067b3..2717149170d 100644
--- a/src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c
+++ b/src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c
@@ -124,7 +124,6 @@ static sql_rcode_t sql_query(rlm_sql_handle_t *handle, UNUSED rlm_sql_config_t *
 		      (long int) conn->sql_code, conn->error, query);
 
 		if (conn->sql_code == DOWN_SQL_CODE) {
-		reconnect:
 			pthread_mutex_unlock(&conn->mut);
 
 			return RLM_SQL_RECONNECT;
@@ -135,7 +134,7 @@ static sql_rcode_t sql_query(rlm_sql_handle_t *handle, UNUSED rlm_sql_config_t *
 			//assume the network is down if rollback had failed
 			ERROR("Fail to rollback transaction after previous error: %s", conn->error);
 
-			goto reconnect;
+			return RLM_SQL_RECONNECT;
 		}
 		//   conn->in_use=0;