From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 5 Nov 2020 13:19:11 +0000 (+0100)
Subject: selftest/subunithelper: only let ']\n' lines to terminate
X-Git-Tag: samba-4.14.0rc1~635
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f556d9770a052c6c650183d6ce352d4bc620e53;p=thirdparty%2Fsamba.git

selftest/subunithelper: only let ']\n' lines to terminate

It should not be enough that a line ends with ']\n' is accident,
subunit DETAILS are terminated with '\n]\n'!

This gives a much higher chance to see the actual problem
without having them filtered by various 'filter-subunit' invocations.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/selftest/subunithelper.py b/selftest/subunithelper.py
index baab146ca60..7224ddbaed5 100644
--- a/selftest/subunithelper.py
+++ b/selftest/subunithelper.py
@@ -85,8 +85,7 @@ def parse_results(msg_ops, statistics, fh):
                     if l == "":
                         break
                     msg_ops.control_msg(l)
-                    if l[-2:] == "]\n":
-                        reason += l[:-2]
+                    if l == "]\n":
                         terminated = True
                         break
                     else: