From: Matthijs Mekking <matthijs@isc.org>
Date: Tue, 2 Feb 2021 19:02:54 +0000 (+0100)
Subject: Remove initialize goal code
X-Git-Tag: v9.16.12~7^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f6dafe1f4b53f08454df49db59869f4a37871f6;p=thirdparty%2Fbind9.git

Remove initialize goal code

Since keys now have their goals initialized in 'keymgr_key_init()',
remove this redundant piece of code in 'keymgr_key_run()'.

(cherry picked from commit 82632fa6d92ef37508fc77a14255e4d1ff12e09d)
---

diff --git a/lib/dns/keymgr.c b/lib/dns/keymgr.c
index 170eca37f4b..fccd3c68f4a 100644
--- a/lib/dns/keymgr.c
+++ b/lib/dns/keymgr.c
@@ -1842,19 +1842,6 @@ dns_keymgr_run(const dns_name_t *origin, dns_rdataclass_t rdclass,
 					continue;
 				}
 
-				/*
-				 * This is possibly an active key created
-				 * outside dnssec-policy.  Initialize goal,
-				 * if not set.
-				 */
-				dst_key_state_t goal;
-				if (dst_key_getstate(dkey->key, DST_KEY_GOAL,
-						     &goal) != ISC_R_SUCCESS) {
-					dst_key_setstate(dkey->key,
-							 DST_KEY_GOAL,
-							 OMNIPRESENT);
-				}
-
 				/*
 				 * Save the matched key only if it is active
 				 * or desires to be active.