From: Philippe Mathieu-Daudé Date: Wed, 17 Dec 2025 08:55:02 +0000 (+0000) Subject: target/hexagon: Include missing 'cpu.h' header in 'internal.h' X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f76eeb4b4ae2ce3d296e4c26a8b1918108cb31e;p=thirdparty%2Fqemu.git target/hexagon: Include missing 'cpu.h' header in 'internal.h' Both CPUHexagonState and TOTAL_PER_THREAD_REGS are defined in "cpu.h" which is luckily indirectly included. However when refactoring unrelated files we get: In file included from target/hexagon/helper.h:18, from include/exec/helper-proto.h.inc:56, from include/exec/helper-proto.h:13, from target/hexagon/op_helper.c:22: target/hexagon/internal.h: At top level: target/hexagon/internal.h:29:25: error: unknown type name ‘CPUHexagonState’; did you mean ‘CPUPluginState’? 29 | void hexagon_debug_vreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:30:25: error: unknown type name ‘CPUHexagonState’; did you mean ‘CPUPluginState’? 30 | void hexagon_debug_qreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:31:20: error: unknown type name ‘CPUHexagonState’; did you mean ‘CPUPluginState’? 31 | void hexagon_debug(CPUHexagonState *env); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:33:44: error: ‘TOTAL_PER_THREAD_REGS’ undeclared here (not in a function) 33 | extern const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS]; | ^~~~~~~~~~~~~~~~~~~~~ Fix that by including the missing header. We don't need the "qemu/log.h" since commit 0cb73cb5a02 ("target/hexagon: Remove HEX_DEBUG/HEX_DEBUG_LOG"): remove it. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Matheus Tavares Bernardino Reviewed-by: Brian Cain Message-Id: <20251224134644.85582-9-philmd@linaro.org> --- diff --git a/target/hexagon/internal.h b/target/hexagon/internal.h index 32e96f00d9..5fc837ae22 100644 --- a/target/hexagon/internal.h +++ b/target/hexagon/internal.h @@ -18,7 +18,7 @@ #ifndef HEXAGON_INTERNAL_H #define HEXAGON_INTERNAL_H -#include "qemu/log.h" +#include "target/hexagon/cpu.h" int hexagon_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); int hexagon_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);