From: Alyssa Ross <hi@alyssa.is>
Date: Sun, 28 Jul 2024 10:50:37 +0000 (+0200)
Subject: test: use "tty" group rather than "bin"
X-Git-Tag: dbus-1.15.10~8^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f988b9fb39fc073b11466db6f5118a267fbb5cc;p=thirdparty%2Fdbus.git

test: use "tty" group rather than "bin"

Unlike "bin", "tty" actually means something on modern Linux distros,
and is used by a default udev rule, so it's more likely to exist on
distros than a group that just exists for historical compatibility
with who knows what.

"tty" exists on macOS, Debian, and Fedora (the criteria used for
choosing "bin" in f2905def ("policy tests: Use bin rather than
nogroup, wheel, or root")), but also fixes running the bus test for me
on NixOS, which has "tty" but not "bin".

Closes: https://gitlab.freedesktop.org/dbus/dbus/-/issues/514
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---

diff --git a/test/data/valid-config-files-system/many-rules.conf b/test/data/valid-config-files-system/many-rules.conf
index 8e8930656..59239258b 100644
--- a/test/data/valid-config-files-system/many-rules.conf
+++ b/test/data/valid-config-files-system/many-rules.conf
@@ -18,7 +18,7 @@
     <deny send_destination="org.freedesktop.System"/>
     <deny receive_sender="org.freedesktop.System"/>
     <deny user="root"/>
-    <deny group="bin"/>
+    <deny group="tty"/>
     <allow send_type="error"/>
     <allow send_type="method_call"/>
     <allow send_type="method_return"/>
@@ -38,7 +38,7 @@
     <deny send_destination="org.freedesktop.System"/>
     <deny receive_sender="org.freedesktop.System"/>
     <deny user="root"/>
-    <deny group="bin"/>
+    <deny group="tty"/>
     <allow send_type="error"/>
     <allow send_type="method_call"/>
     <allow send_type="method_return"/>
@@ -47,7 +47,7 @@
     <deny send_destination="org.freedesktop.Bar" send_interface="org.freedesktop.Foo" send_type="method_call"/>
   </policy>
 
-  <policy group="bin"/>
+  <policy group="tty"/>
   <policy at_console="true"/>
   <policy at_console="false"/>