From: Jelte Jansen <jelte@isc.org>
Date: Mon, 10 Dec 2012 23:37:04 +0000 (+0100)
Subject: [2445] Remove setLogLevel(TRACE) in createBufferAppender
X-Git-Tag: bind10-1.0.0-beta-release~19^2~17^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3f9c7bb8a987dc1b4e2a9266ac95cf231d8fe621;p=thirdparty%2Fkea.git

[2445] Remove setLogLevel(TRACE) in createBufferAppender

This has a chance that some log messages get lost (DEBUG messages during startup in case -v is not given but the config has DEBUG set)
---

diff --git a/src/lib/log/logger_manager_impl.cc b/src/lib/log/logger_manager_impl.cc
index 6862d0cb51..3d12571cf3 100644
--- a/src/lib/log/logger_manager_impl.cc
+++ b/src/lib/log/logger_manager_impl.cc
@@ -145,9 +145,6 @@ LoggerManagerImpl::createBufferAppender(log4cplus::Logger& logger) {
     log4cplus::SharedAppenderPtr bufferapp(new internal::BufferAppender());
     bufferapp->setName("buffer");
     logger.addAppender(bufferapp);
-    // Since we do not know at what level the loggers will end up
-    // running, set it to the highest for now
-    logger.setLogLevel(log4cplus::TRACE_LOG_LEVEL);
 }
 
 // Syslog appender.
diff --git a/src/lib/log/tests/buffer_logger_test.cc b/src/lib/log/tests/buffer_logger_test.cc
index 8d1b3cf519..84fb7973f8 100644
--- a/src/lib/log/tests/buffer_logger_test.cc
+++ b/src/lib/log/tests/buffer_logger_test.cc
@@ -22,7 +22,7 @@ using namespace isc::log;
 
 namespace {
 void usage() {
-    std::cout << "Usage: buffer_logger_test [-n]" << std::endl;
+    std::cout << "Usage: buffer_logger_test [-nv]" << std::endl;
 }
 } // end unnamed namespace
 
@@ -52,10 +52,10 @@ main(int argc, char** argv) {
         }
     }
 
-    // Note, level is INFO, so DEBUG should normally not show
-    // up. Unless process is never called (at which point it
-    // will end up in the dump at the end).
-    initLogger("buffertest", isc::log::INFO, 0, NULL, true);
+    // Note, level is set to DEBUG here, but back to INFO
+    // in process(), so when flushing to stdout (-n), the DEBUG
+    // message should show up
+    initLogger("buffertest", isc::log::DEBUG, 99, NULL, true);
     Logger logger("log");
     // No need for file interprocess locking in this test
     logger.setInterprocessSync(new isc::util::InterprocessSyncNull("logger"));