From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Sun, 26 Jul 2026 16:40:26 +0000 (+0100)
Subject: modinfo: skip parm entries without a name
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3fb109c628e2ae9309303b316f5812dcdea2dea8;p=thirdparty%2Fkmod.git

modinfo: skip parm entries without a name

Specially crafted/corrupt modules may have a parm/parmtype entry which
lacks the "name:" prefix. Throw a warning and skip such entries.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/451
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
---

diff --git a/tools/modinfo.c b/tools/modinfo.c
index 2457fd2a..ff338d76 100644
--- a/tools/modinfo.c
+++ b/tools/modinfo.c
@@ -88,6 +88,11 @@ static int process_parm(const char *key, const char *value, struct param **param
 		return 0;
 	}
 
+	if (colon == value) {
+		ERR("Missing param name in value \"%s\"\n", value);
+		return 0;
+	}
+
 	name = value;
 	namelen = colon - value;
 	if (streq(key, "parm")) {