From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Mon, 5 Apr 2021 05:11:04 +0000 (+0200)
Subject: ids.cgi: Sort elements in providers dropdown menu.
X-Git-Tag: v2.27-core164~210^2~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4015d3f499c85cece577e360277cdc0e95a3d083;p=ipfire-2.x.git

ids.cgi: Sort elements in providers dropdown menu.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 8ee16930a3..0f039c33c3 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -1748,10 +1748,23 @@ END
 					}
 
 					print "<select name='PROVIDER' id='PROVIDER' $disabled>\n";
+						# Temporary hash to store the provier names and their handles.
+						my %tmphash = ();
+
 						# Loop through the array of ruleset providers.
-						foreach my $provider (@ruleset_providers) {
+						foreach my $handle (@ruleset_providers) {
 							# Get the provider name.
-							my $provider_name = &get_provider_name($provider);
+							my $name = &get_provider_name($handle);
+
+							# Add the grabbed provider  name and handle to the
+							# temporary hash.
+							$tmphash{$name} = "$handle";
+						}
+
+						# Sort and loop through the temporary hash.
+						foreach my $provider_name ( sort keys %tmphash ) {
+							# Grab the provider handle.
+							my $provider = $tmphash{$provider_name};
 
 							# Pre-select the provider if one is given.
 							if (($used_providers{$cgiparams{'ID'}}[0] eq "$provider") || ($cgiparams{'PROVIDER'} eq "$provider")) {