From: Christian Brauner Date: Mon, 1 Feb 2021 13:51:41 +0000 (+0100) Subject: attach: fix error checking for dup2() X-Git-Tag: lxc-5.0.0~309^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40301d4895f0ca4f43d0aa1060e7d3c40e1ec562;p=thirdparty%2Flxc.git attach: fix error checking for dup2() Signed-off-by: Christian Brauner --- diff --git a/src/lxc/attach.c b/src/lxc/attach.c index 3dc5b1a10..60666eebd 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -1129,15 +1129,15 @@ __noreturn static void do_attach(struct attach_payload *ap) * may want to make sure the fds are closed, for example. */ if (options->stdin_fd >= 0 && options->stdin_fd != STDIN_FILENO) - if (dup2(options->stdin_fd, STDIN_FILENO)) + if (dup2(options->stdin_fd, STDIN_FILENO) < 0) SYSDEBUG("Failed to replace stdin with %d", options->stdin_fd); if (options->stdout_fd >= 0 && options->stdout_fd != STDOUT_FILENO) - if (dup2(options->stdout_fd, STDOUT_FILENO)) + if (dup2(options->stdout_fd, STDOUT_FILENO) < 0) SYSDEBUG("Failed to replace stdout with %d", options->stdout_fd); if (options->stderr_fd >= 0 && options->stderr_fd != STDERR_FILENO) - if (dup2(options->stderr_fd, STDERR_FILENO)) + if (dup2(options->stderr_fd, STDERR_FILENO) < 0) SYSDEBUG("Failed to replace stderr with %d", options->stderr_fd); /* close the old fds */