From: Harald Hoyer <harald@redhat.com>
Date: Fri, 26 Mar 2021 09:29:12 +0000 (+0100)
Subject: fix(dbus-daemon): shellcheck for modules.d/06dbus-daemon
X-Git-Tag: 054~260
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4042816955e41b457b72d95d8e6057add168d0c1;p=thirdparty%2Fdracut.git

fix(dbus-daemon): shellcheck for modules.d/06dbus-daemon
---

diff --git a/modules.d/06dbus-daemon/.shchkdir b/modules.d/06dbus-daemon/.shchkdir
new file mode 100644
index 000000000..e69de29bb
diff --git a/modules.d/06dbus-daemon/module-setup.sh b/modules.d/06dbus-daemon/module-setup.sh
index df86ffeaa..29f669fec 100755
--- a/modules.d/06dbus-daemon/module-setup.sh
+++ b/modules.d/06dbus-daemon/module-setup.sh
@@ -33,30 +33,31 @@ depends() {
 install() {
 
     # Create dbus related directories.
-    inst_dir $dbus
-    inst_dir $dbusinterfaces
-    inst_dir $dbusservices
-    inst_dir $dbussession
-    inst_dir $dbussystem
-    inst_dir $dbussystemservices
-    inst_dir $dbusconfdir
-    inst_dir $dbusinterfacesconfdir
-    inst_dir $dbusservicesconfdir
-    inst_dir $dbussessionconfdir
-    inst_dir $dbussystemconfdir
-    inst_dir $dbussystemservicesconfdir
+    inst_dir "$dbus"
+    inst_dir "$dbusinterfaces"
+    inst_dir "$dbusservices"
+    inst_dir "$dbussession"
+    inst_dir "$dbussystem"
+    inst_dir "$dbussystemservices"
+    inst_dir "$dbusconfdir"
+    inst_dir "$dbusinterfacesconfdir"
+    inst_dir "$dbusservicesconfdir"
+    inst_dir "$dbussessionconfdir"
+    inst_dir "$dbussystemconfdir"
+    inst_dir "$dbussystemservicesconfdir"
 
     inst_multiple -o \
-        $dbus/system.conf \
-        $dbussystem/org.freedesktop.systemd1.conf \
-        $dbusservicesconfdir/org.freedesktop.systemd1.service \
-        $dbussystemservices/org.freedesktop.systemd1.service \
-        $systemdsystemunitdir/dbus.service \
-        $systemdsystemunitdir/dbus.socket \
-        $systemdsystemunitdir/dbus.target.wants \
+        "$dbus"/system.conf \
+        "$dbussystem"/org.freedesktop.systemd1.conf \
+        "$dbusservicesconfdir"/org.freedesktop.systemd1.service \
+        "$dbussystemservices"/org.freedesktop.systemd1.service \
+        "$systemdsystemunitdir"/dbus.service \
+        "$systemdsystemunitdir"/dbus.socket \
+        "$systemdsystemunitdir"/dbus.target.wants \
         busctl dbus-send dbus-daemon
 
     # Adjusting dependencies for initramfs in the dbus service unit.
+    # shellcheck disable=SC1004
     sed -i -e \
         '/^\[Unit\]/aDefaultDependencies=no\
         Conflicts=shutdown.target\
@@ -64,6 +65,7 @@ install() {
         "$initdir$systemdsystemunitdir/dbus.service"
 
     # Adjusting dependencies for initramfs in the dbus socket unit.
+    # shellcheck disable=SC1004
     sed -i -e \
         '/^\[Unit\]/aDefaultDependencies=no\
         Conflicts=shutdown.target\
@@ -78,12 +80,11 @@ install() {
     # Install the hosts local user configurations if enabled.
     if [[ $hostonly ]]; then
         inst_multiple -H -o \
-            $dbusconfdir/system.conf \
-            $systemdsystemconfdir/dbus.socket \
-            $systemdsystemconfdir/dbus.socket.d/*.conf \
-            $systemdsystemconfdir/dbus.service \
-            $systemdsystemconfdir/dbus.service.d/*.conf \
-            ${NULL}
+            "$dbusconfdir"/system.conf \
+            "$systemdsystemconfdir"/dbus.socket \
+            "$systemdsystemconfdir"/dbus.socket.d/*.conf \
+            "$systemdsystemconfdir"/dbus.service \
+            "$systemdsystemconfdir"/dbus.service.d/*.conf
     fi
 
     # We need to make sure that systemd-tmpfiles-setup.service->dbus.socket