From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 29 Jul 2021 13:53:45 +0000 (-0400)
Subject: set extra=0 only when min=max.  Fixes #4163
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=405fe4e9c784720ea8105c00f3ca97d669be42b6;p=thirdparty%2Ffreeradius-server.git

set extra=0 only when min=max.  Fixes #4163
---

diff --git a/src/lib/server/pool.c b/src/lib/server/pool.c
index ef7de91b59c..bb93a3b131a 100644
--- a/src/lib/server/pool.c
+++ b/src/lib/server/pool.c
@@ -677,11 +677,12 @@ static int connection_check(fr_pool_t *pool, request_t *request)
 
 	/*
 	 *	But if we're already at "min", then don't spawn more,
-	 *	and we don't have any extra idle connections.
+	 *	and set extra to zero if there's no possibility for extra.
 	 */
 	} else if ((pool->state.num + pool->state.pending) >= pool->min) {
 		spawn = 0;
-		extra = 0;
+
+		if (pool->min == pool->max) extra = 0;
 
 	/*
 	 *	If we're about to create more than "max",