From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 3 Sep 2025 08:38:59 +0000 (+0200)
Subject: bootctl: output a more precise log message when updating existing EFI vars
X-Git-Tag: v259-rc1~487^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=407139ae92e527ff66a7302165d3690eb24ac3f9;p=thirdparty%2Fsystemd.git

bootctl: output a more precise log message when updating existing EFI vars
---

diff --git a/src/bootctl/bootctl-install.c b/src/bootctl/bootctl-install.c
index 89a82192f87..b70e945ca7a 100644
--- a/src/bootctl/bootctl-install.c
+++ b/src/bootctl/bootctl-install.c
@@ -906,10 +906,17 @@ static int install_variables(
                 return graceful ? 0 : r;
         }
 
-        if (first || r == 0) {
-                r = efi_add_boot_option(slot, pick_efi_boot_option_description(),
-                                        part, pstart, psize,
-                                        uuid, path);
+        bool existing = r > 0;
+
+        if (first || !existing) {
+                r = efi_add_boot_option(
+                                slot,
+                                pick_efi_boot_option_description(),
+                                part,
+                                pstart,
+                                psize,
+                                uuid,
+                                path);
                 if (r < 0) {
                         int level = graceful ? arg_quiet ? LOG_DEBUG : LOG_INFO : LOG_ERR;
                         const char *skip = graceful ? ", skipping" : "";
@@ -919,7 +926,9 @@ static int install_variables(
                         return graceful ? 0 : r;
                 }
 
-                log_info("Created EFI boot entry \"%s\".", pick_efi_boot_option_description());
+                log_info("%s EFI boot entry \"%s\".",
+                         existing ? "Updated" : "Created",
+                         pick_efi_boot_option_description());
         }
 
         return insert_into_order(slot, first);