From: Michael Brown <mcb30@etherboot.org>
Date: Tue, 10 Jul 2007 05:25:30 +0000 (+0100)
Subject: Unplug before sending close() message, to avoid screwing up interfaces
X-Git-Tag: v0.9.3~220
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4075f7596bd7b879706516fd84f4acbf19a7d2c5;p=thirdparty%2Fipxe.git

Unplug before sending close() message, to avoid screwing up interfaces
which respond to close with a reopen() (e.g. iSCSI).
---

diff --git a/src/core/job.c b/src/core/job.c
index 00c0e6c41..6c2faf30f 100644
--- a/src/core/job.c
+++ b/src/core/job.c
@@ -29,16 +29,16 @@
 void job_done ( struct job_interface *job, int rc ) {
 	struct job_interface *dest = job_get_dest ( job );
 
-	dest->op->done ( dest, rc );
 	job_unplug ( job );
+	dest->op->done ( dest, rc );
 	job_put ( dest );
 }
 
 void job_kill ( struct job_interface *job ) {
 	struct job_interface *dest = job_get_dest ( job );
 
-	dest->op->kill ( dest );
 	job_unplug ( job );
+	dest->op->kill ( dest );
 	job_put ( dest );
 }
 
diff --git a/src/core/resolv.c b/src/core/resolv.c
index 5c25ddb12..808ab657f 100644
--- a/src/core/resolv.c
+++ b/src/core/resolv.c
@@ -50,8 +50,8 @@ void resolv_done ( struct resolv_interface *resolv, struct sockaddr *sa,
 		   int rc ) {
 	struct resolv_interface *dest = resolv_get_dest ( resolv );
 
-	dest->op->done ( dest, sa, rc );
 	resolv_unplug ( resolv );
+	dest->op->done ( dest, sa, rc );
 	resolv_put ( dest );
 }
 
diff --git a/src/core/xfer.c b/src/core/xfer.c
index 068958711..3add057b9 100644
--- a/src/core/xfer.c
+++ b/src/core/xfer.c
@@ -38,8 +38,8 @@ void xfer_close ( struct xfer_interface *xfer, int rc ) {
 
 	DBGC ( xfer, "XFER %p->%p close\n", xfer, dest );
 
-	dest->op->close ( dest, rc );
 	xfer_unplug ( xfer );
+	dest->op->close ( dest, rc );
 	xfer_put ( dest );
 }