From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 2 Dec 2022 10:01:06 +0000 (+0100)
Subject: virNetDevVPortProfileParse: Use virXMLNodeGetSubelement to find '<parameters>'
X-Git-Tag: v9.1.0-rc1~104
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4088b5afa36af9c46b34a13918f4e2f6543af79a;p=thirdparty%2Flibvirt.git

virNetDevVPortProfileParse: Use virXMLNodeGetSubelement to find '<parameters>'

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/conf/netdev_vport_profile_conf.c b/src/conf/netdev_vport_profile_conf.c
index cdde7efcd9..26f379248f 100644
--- a/src/conf/netdev_vport_profile_conf.c
+++ b/src/conf/netdev_vport_profile_conf.c
@@ -36,7 +36,7 @@ virNetDevVPortProfileParse(xmlNodePtr node, unsigned int flags)
     g_autofree char *virtPortProfileID = NULL;
     g_autofree char *virtPortInterfaceID = NULL;
     g_autofree virNetDevVPortProfile *virtPort = NULL;
-    xmlNodePtr cur = node->children;
+    xmlNodePtr parameters;
 
     virtPort = g_new0(virNetDevVPortProfile, 1);
 
@@ -54,17 +54,13 @@ virNetDevVPortProfileParse(xmlNodePtr node, unsigned int flags)
         return NULL;
     }
 
-    while (cur != NULL) {
-        if (virXMLNodeNameEqual(cur, "parameters")) {
-            virtPortManagerID = virXMLPropString(cur, "managerid");
-            virtPortTypeID = virXMLPropString(cur, "typeid");
-            virtPortTypeIDVersion = virXMLPropString(cur, "typeidversion");
-            virtPortInstanceID = virXMLPropString(cur, "instanceid");
-            virtPortProfileID = virXMLPropString(cur, "profileid");
-            virtPortInterfaceID = virXMLPropString(cur, "interfaceid");
-            break;
-        }
-        cur = cur->next;
+    if ((parameters = virXMLNodeGetSubelement(node, "parameters"))) {
+        virtPortManagerID = virXMLPropString(parameters, "managerid");
+        virtPortTypeID = virXMLPropString(parameters, "typeid");
+        virtPortTypeIDVersion = virXMLPropString(parameters, "typeidversion");
+        virtPortInstanceID = virXMLPropString(parameters, "instanceid");
+        virtPortProfileID = virXMLPropString(parameters, "profileid");
+        virtPortInterfaceID = virXMLPropString(parameters, "interfaceid");
     }
 
     if (virtPortManagerID) {