From: Andrew Goodbody Date: Tue, 21 Oct 2025 16:08:29 +0000 (+0100) Subject: i2c: imx_lpi2c: Fix error detection X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40ad377c1619eb9b83d088a96f40b86a907c8c19;p=thirdparty%2Fu-boot.git i2c: imx_lpi2c: Fix error detection Testing an unisgned ivariable to be <= 0 will only detect the case when it is 0. So correct this error test to a working version that will behave as expected. Signed-off-by: Andrew Goodbody Reviewed-by: Heiko Schocher --- diff --git a/drivers/i2c/imx_lpi2c.c b/drivers/i2c/imx_lpi2c.c index 4636da9f301..a309fd6f07c 100644 --- a/drivers/i2c/imx_lpi2c.c +++ b/drivers/i2c/imx_lpi2c.c @@ -304,7 +304,7 @@ static int bus_i2c_set_bus_speed(struct udevice *bus, int speed) if (CONFIG_IS_ENABLED(CLK)) { clock_rate = clk_get_rate(&i2c_bus->per_clk); - if (clock_rate <= 0) { + if (!clock_rate || IS_ERR_VALUE(clock_rate)) { dev_err(bus, "Failed to get i2c clk: %d\n", clock_rate); return clock_rate; }