From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Mon, 4 Oct 2010 14:37:32 +0000 (-0600)
Subject: Accept ICAP OPTIONS responses with unknown body types.
X-Git-Tag: take1~210
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40bb98876a819fc65e36598d94674c2d572d5392;p=thirdparty%2Fsquid.git

Accept ICAP OPTIONS responses with unknown body types.

Warn about the unknown OPTIONS body type but ignore it instead of rejecting
the entire OPTIONS response. Note that ICAP does not standardize OPTIONS
body types, and Squid does not recognize any body type.

ICAP servers are supposed to negotiate the use of OPTIONS bodies but
negotiation mechanism is not standardized and some do not negotiate at all.
---

diff --git a/src/adaptation/icap/Options.cc b/src/adaptation/icap/Options.cc
index 4cf37cb337..05fcfa312e 100644
--- a/src/adaptation/icap/Options.cc
+++ b/src/adaptation/icap/Options.cc
@@ -90,8 +90,12 @@ void Adaptation::Icap::Options::configure(const HttpReply *reply)
 
     istag = h->getByName("ISTag");
 
-    if (h->getByName("Opt-body-type").size())
-        error = "ICAP service returns unsupported OPTIONS body";
+    if (h->getByName("Opt-body-type").size()) {
+        // TODO: add a class to rate-limit such warnings using FadingCounter
+        debugs(93,DBG_IMPORTANT, "WARNING: Ignoring unsupported ICAP " <<
+            "OPTIONS body; type: " << h->getByName("Opt-body-type"));
+        // Do not set error, assuming the response headers are valid.
+    }
 
     cfgIntHeader(h, "Max-Connections", max_connections);