From: lpsolit%gmail.com <>
Date: Sat, 5 Nov 2005 20:24:29 +0000 (+0000)
Subject: Bug 315129: [PostgreSQL] Attachments are sorted by last changed time instead of creat... 
X-Git-Tag: bugzilla-2.22rc1~166
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40cec31b70098cc0916ace383d426d812d19d044;p=thirdparty%2Fbugzilla.git

Bug 315129: [PostgreSQL] Attachments are sorted by last changed time instead of creation time - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave
---

diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm
index c4e7580ae5..bb40e74c94 100644
--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -100,7 +100,8 @@ sub _retrieve {
     my $records = Bugzilla->dbh->selectall_arrayref("SELECT $columns
                                                      FROM attachments
                                                      WHERE attach_id IN (" .
-                                                     join(",", @$ids) . ")",
+                                                     join(",", @$ids) . ")
+                                                     ORDER BY attach_id",
                                                     { Slice => {} });
     return $records;
 }
@@ -394,8 +395,7 @@ sub get_attachments_by_bug {
     my ($class, $bug_id) = @_;
     my $attach_ids = Bugzilla->dbh->selectcol_arrayref("SELECT attach_id
                                                         FROM attachments
-                                                        WHERE bug_id = ?
-                                                        ORDER BY attach_id",
+                                                        WHERE bug_id = ?",
                                                        undef, $bug_id);
     my $attachments = Bugzilla::Attachment->get_list($attach_ids);
     return $attachments;