From: Greg Hudson <ghudson@mit.edu>
Date: Fri, 2 Aug 2013 15:37:40 +0000 (-0400)
Subject: Fix leak in krb5_krcc_unparse_cred on error
X-Git-Tag: krb5-1.12-alpha1~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40d8ad25e2160583c6d74a10e7599253d3b292ce;p=thirdparty%2Fkrb5.git

Fix leak in krb5_krcc_unparse_cred on error

Based on a patch from simo@redhat.com.
---

diff --git a/src/lib/krb5/ccache/cc_keyring.c b/src/lib/krb5/ccache/cc_keyring.c
index 3828c5949a..55c7711dd4 100644
--- a/src/lib/krb5/ccache/cc_keyring.c
+++ b/src/lib/krb5/ccache/cc_keyring.c
@@ -1913,7 +1913,7 @@ krb5_krcc_unparse_cred(krb5_context context, krb5_ccache id,
                        krb5_creds * creds, char **datapp, unsigned int *lenptr)
 {
     krb5_error_code kret;
-    char   *buf;
+    char *buf = NULL;
     krb5_krcc_bc bc;
 
     if (!creds || !datapp || !lenptr)
@@ -1963,9 +1963,11 @@ krb5_krcc_unparse_cred(krb5_context context, krb5_ccache id,
     /* Success! */
     *datapp = buf;
     *lenptr = bc.bpp - buf;
+    buf = NULL;
     kret = KRB5_OK;
 
 errout:
+    free(buf);
     return kret;
 }