From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Tue, 24 Aug 2021 21:08:29 +0000 (+0200)
Subject: Drop TODO point regarding Travis
X-Git-Tag: 3.0.beta1~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40df2bb829187eae207fc50d7c24adf7625b88d2;p=thirdparty%2Fpsycopg.git

Drop TODO point regarding Travis

On GitHub Action it's OK.

On flaky platforms these tests are skipped, so let's fail hard if the
proxy fails to come up.
---

diff --git a/tests/fix_proxy.py b/tests/fix_proxy.py
index 33df7a24b..83fce5c9f 100644
--- a/tests/fix_proxy.py
+++ b/tests/fix_proxy.py
@@ -82,12 +82,11 @@ class Proxy:
         self._wait_listen()
 
         # verify that the proxy works
-        # TODO: investigate why it doesn't on Travis
         try:
             with psycopg.connect(self.client_dsn):
                 pass
         except Exception as e:
-            pytest.xfail(f"failed to create a working proxy: {e}")
+            pytest.fail(f"failed to create a working proxy: {e}")
 
     def stop(self):
         if not self.proc: