From: Jouni Malinen <j@w1.fi>
Date: Fri, 15 Jul 2011 10:42:06 +0000 (+0300)
Subject: MD5: Fix clearing of temporary stack memory to use correct length
X-Git-Tag: hostap-1-bp~318
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40eebf235370b6fe6353784ccf01ab92eed062a5;p=thirdparty%2Fhostap.git

MD5: Fix clearing of temporary stack memory to use correct length

sizeof of the structure instead of the pointer was supposed to be used
here. Fix this to clear the full structure at the end of MD5Final().
---

diff --git a/src/crypto/md5-internal.c b/src/crypto/md5-internal.c
index f8692a955..137ad9150 100644
--- a/src/crypto/md5-internal.c
+++ b/src/crypto/md5-internal.c
@@ -188,7 +188,7 @@ void MD5Final(unsigned char digest[16], struct MD5Context *ctx)
     MD5Transform(ctx->buf, (u32 *) ctx->in);
     byteReverse((unsigned char *) ctx->buf, 4);
     os_memcpy(digest, ctx->buf, 16);
-    os_memset(ctx, 0, sizeof(ctx));	/* In case it's sensitive */
+    os_memset(ctx, 0, sizeof(*ctx));	/* In case it's sensitive */
 }
 
 /* The four core functions - F1 is optimized somewhat */