From: Andrew Tridgell Date: Mon, 29 Sep 2008 23:50:46 +0000 (-0700) Subject: we need to return NT_STATUS_INVALID_PARAMETER for bad levels in X-Git-Tag: samba-4.0.0alpha6~769^2~228^2~101 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=40fa4c4154aa572f39fddf16b2fefbe370910360;p=thirdparty%2Fsamba.git we need to return NT_STATUS_INVALID_PARAMETER for bad levels in lsalookupnames2 --- diff --git a/source4/rpc_server/lsa/lsa_lookup.c b/source4/rpc_server/lsa/lsa_lookup.c index 5f080e6da23..7bf7d849b74 100644 --- a/source4/rpc_server/lsa/lsa_lookup.c +++ b/source4/rpc_server/lsa/lsa_lookup.c @@ -862,6 +862,11 @@ NTSTATUS dcesrv_lsa_LookupNames2(struct dcesrv_call_state *dce_call, DCESRV_PULL_HANDLE(h, r->in.handle, LSA_HANDLE_POLICY); + if (r->in.level < LSA_LOOKUP_NAMES_ALL || + r->in.level > LSA_LOOKUP_NAMES_RODC_REFERRAL_TO_FULL_DC) { + return NT_STATUS_INVALID_PARAMETER; + } + state = h->data; r->out.domains = talloc_zero(mem_ctx, struct lsa_RefDomainList);