From: Roy Marples <roy@marples.name>
Date: Mon, 24 Jun 2024 11:05:58 +0000 (+0100)
Subject: IPv6: make more readable (nfc)
X-Git-Tag: v10.0.9~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=410fae4e558278fad1261277e9f977f0866eea93;p=thirdparty%2Fdhcpcd.git

IPv6: make more readable (nfc)
---

diff --git a/src/ipv6.c b/src/ipv6.c
index 01734f65..022e82a0 100644
--- a/src/ipv6.c
+++ b/src/ipv6.c
@@ -1397,18 +1397,17 @@ ipv6_addlinklocalcallback(struct interface *ifp,
 	state = ipv6_getstate(ifp);
 	TAILQ_FOREACH(cb, &state->ll_callbacks, next) {
 		if (cb->callback == callback && cb->arg == arg)
-			break;
+			return 0;
 	}
+
+	cb = malloc(sizeof(*cb));
 	if (cb == NULL) {
-		cb = malloc(sizeof(*cb));
-		if (cb == NULL) {
-			logerr(__func__);
-			return -1;
-		}
-		cb->callback = callback;
-		cb->arg = arg;
-		TAILQ_INSERT_TAIL(&state->ll_callbacks, cb, next);
+		logerr(__func__);
+		return -1;
 	}
+	cb->callback = callback;
+	cb->arg = arg;
+	TAILQ_INSERT_TAIL(&state->ll_callbacks, cb, next);
 	return 0;
 }