From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Mon, 21 Mar 2022 11:01:22 +0000 (+0100)
Subject: BUG/MINOR: quic: Non initialized variable in quic_build_post_handshake_frames()
X-Git-Tag: v2.6-dev4~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=411aa6daf57495374b41178176d1056d243cc610;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Non initialized variable in quic_build_post_handshake_frames()

<cid> could be accessed before being initialized.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index a386d81062..b9aaeabaf1 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2983,14 +2983,15 @@ static int quic_build_post_handshake_frames(struct quic_conn *qc)
 	while (node) {
 		struct quic_connection_id *cid;
 
+
+		cid = eb64_entry(&node->node, struct quic_connection_id, seq_num);
 		if (cid->seq_num.key >= max)
 			break;
 
-		cid = eb64_entry(&node->node, struct quic_connection_id, seq_num);
-		node = eb64_next(node);
 		if (cid->seq_num.key < first)
 			continue;
 
+		node = eb64_next(node);
 		ebmb_delete(&cid->node);
 		eb64_delete(&cid->seq_num);
 		pool_free(pool_head_quic_connection_id, cid);