From: Aram Sargsyan <aram@isc.org>
Date: Fri, 27 Sep 2024 12:48:22 +0000 (+0000)
Subject: Add a missing rcu_read_unlock() call on exit path
X-Git-Tag: v9.21.2~12^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4123d59fbc3fc5139b5e43370238ca13a290e07c;p=thirdparty%2Fbind9.git

Add a missing rcu_read_unlock() call on exit path

An exit path in the dns_dispatch_add() function fails to get out of
the RCU critical section when returning early. Add the missing
rcu_read_unlock() call.
---

diff --git a/lib/dns/dispatch.c b/lib/dns/dispatch.c
index e4fd46bd308..5a08a065770 100644
--- a/lib/dns/dispatch.c
+++ b/lib/dns/dispatch.c
@@ -1494,6 +1494,7 @@ dns_dispatch_add(dns_dispatch_t *disp, isc_loop_t *loop,
 fail:
 	if (result != ISC_R_SUCCESS) {
 		isc_mem_put(disp->mctx, resp, sizeof(*resp));
+		rcu_read_unlock();
 		return (result);
 	}