From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Fri, 27 Oct 2023 13:53:30 +0000 (+0200)
Subject: Cleanup UeberBackend::getSOAUncached
X-Git-Tag: rec-5.0.0-beta1~16^2~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4136873caba27d28e72fc1097bfdfbc5718dfb57;p=thirdparty%2Fpdns.git

Cleanup UeberBackend::getSOAUncached
---

diff --git a/pdns/ueberbackend.cc b/pdns/ueberbackend.cc
index 8ca758a875..64de6d8c54 100644
--- a/pdns/ueberbackend.cc
+++ b/pdns/ueberbackend.cc
@@ -491,7 +491,7 @@ bool UeberBackend::getSOAUncached(const DNSName& domain, SOAData& sd)
   d_question.qname = domain;
   d_question.zoneId = -1;
 
-  for (auto backend : backends)
+  for (auto* backend : backends) {
     if (backend->getSOA(domain, sd)) {
       if (domain != sd.qname) {
         throw PDNSException("getSOA() returned an SOA for the wrong zone. Question: '" + domain.toLogString() + "', answer: '" + sd.qname.toLogString() + "'");
@@ -508,9 +508,11 @@ bool UeberBackend::getSOAUncached(const DNSName& domain, SOAData& sd)
       }
       return true;
     }
+  }
 
-  if (d_negcache_ttl)
+  if (d_negcache_ttl) {
     addNegCache(d_question);
+  }
   return false;
 }