From: Saeed Mahameed Date: Tue, 26 Nov 2024 09:08:28 +0000 (+0100) Subject: devlink: use the correct handle flag for port param show X-Git-Tag: v6.13.0~11 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=413cf4f03a9b6a219c94b86f41d67992b0a14b82;p=thirdparty%2Fiproute2.git devlink: use the correct handle flag for port param show Port param show command arg parser used the devlink dev flag instead of the port, which caused to not identify the port device argument, causing the following error: $ devlink port param show eth0 name link_type Wrong identification string format. Devlink identification ("bus_name/dev_name") expected Use the correct the devlink handle flag. Fixes: 70faecdca8f5 ("devlink: implement dump selector for devlink objects show commands") Signed-off-by: Saeed Mahameed Signed-off-by: Jiri Pirko Signed-off-by: Stephen Hemminger --- diff --git a/devlink/devlink.c b/devlink/devlink.c index bba1bbf1..d14f3f45 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -5089,7 +5089,7 @@ static int cmd_port_param_show(struct dl *dl) err = dl_argv_parse_with_selector(dl, &flags, DEVLINK_CMD_PORT_PARAM_GET, - DL_OPT_HANDLE | DL_OPT_PARAM_NAME, 0, + DL_OPT_HANDLEP | DL_OPT_PARAM_NAME, 0, DL_OPT_HANDLE | DL_OPT_HANDLEP, 0); if (err) return err;