From: Volker Lendecke <vl@samba.org>
Date: Wed, 30 Nov 2022 13:28:54 +0000 (+0100)
Subject: winbind: Save lines with talloc_asprintf_addbuf()
X-Git-Tag: talloc-2.4.0~244
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4156d37db177b3b047fc0a448912d9bcb9354994;p=thirdparty%2Fsamba.git

winbind: Save lines with talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/winbindd/idmap_ad.c b/source3/winbindd/idmap_ad.c
index e80b823ccdf..1f0dd54456c 100644
--- a/source3/winbindd/idmap_ad.c
+++ b/source3/winbindd/idmap_ad.c
@@ -99,19 +99,12 @@ static TLDAPRC get_attrnames_by_oids(struct tldap_context *ld,
 	size_t num_msgs;
 
 	filter = talloc_strdup(mem_ctx, "(|");
-	if (filter == NULL) {
-		return TLDAP_NO_MEMORY;
-	}
 
 	for (i=0; i<num_oids; i++) {
-		filter = talloc_asprintf_append_buffer(
-			filter, "(attributeId=%s)", oids[i]);
-		if (filter == NULL) {
-			return TLDAP_NO_MEMORY;
-		}
+		talloc_asprintf_addbuf(&filter, "(attributeId=%s)", oids[i]);
 	}
+	talloc_asprintf_addbuf(&filter, ")");
 
-	filter = talloc_asprintf_append_buffer(filter, ")");
 	if (filter == NULL) {
 		return TLDAP_NO_MEMORY;
 	}