From: Russell Bryant <russell@russellbryant.com>
Date: Wed, 24 Nov 2010 20:22:32 +0000 (+0000)
Subject: Fix false reporting of an error by set_format().
X-Git-Tag: 1.4.39-rc1~3^2~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41656ad0bf088c1a080eb2619d3afdab0743658e;p=thirdparty%2Fasterisk.git

Fix false reporting of an error by set_format().

In the case that the native format was able to be changed to match the
new requested format, the code proceeded to attempt to build a translation
path, anyway.  The result would be NULL, since no translation path is
necessary and resulted in this function thinking an error has occurred.
This case is now specifically caught and no attempt to build a translation
path is attempted.

Thanks to our automated tests and bamboo.asterisk.org for catching this problem
and making a whole lot of noise when things started failing.  :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@296082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/channel.c b/main/channel.c
index 8630ded015..175c0bd5e5 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -3403,13 +3403,23 @@ static int set_format(struct ast_channel *chan, int fmt, int *rawformat, int *fo
 	if (*trans)
 		ast_translator_free_path(*trans);
 	/* Build a translation path from the raw format to the desired format */
-	if (!direction)
-		/* reading */
-		*trans = ast_translator_build_path(*format, *rawformat);
-	else
-		/* writing */
-		*trans = ast_translator_build_path(*rawformat, *format);
-	res = *trans ? 0 : -1;
+	if (*format == *rawformat) {
+		/*
+		 * If we were able to swap the native format to the format that
+		 * has been requested, then there is no need to try to build
+		 * a translation path.
+		 */
+		res = 0;
+	} else {
+		if (!direction) {
+			/* reading */
+			*trans = ast_translator_build_path(*format, *rawformat);
+		} else {
+			/* writing */
+			*trans = ast_translator_build_path(*rawformat, *format);
+		}
+		res = *trans ? 0 : -1;
+	}
 	ast_channel_unlock(chan);
 	if (option_debug)
 		ast_log(LOG_DEBUG, "Set channel %s to %s format %s\n", chan->name,