From: Phil Sutter <phil@nwl.cc>
Date: Thu, 14 Dec 2017 19:40:20 +0000 (+0100)
Subject: data_reg: Add a missing break in nftnl_data_reg_snprintf
X-Git-Tag: libnftnl-1.0.9~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4177002b26f025891cc509b54dc76bcf98f1c35f;p=thirdparty%2Flibnftnl.git

data_reg: Add a missing break in nftnl_data_reg_snprintf

The code works fine as-is, but if reg_type == DATA_VALUE &&
output_format == NFTNL_OUTPUT_XML, we fall through to DATA_CHAIN case
and therefore pointlessly check output_format again.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index a246952f..70232028 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -207,6 +207,7 @@ int nftnl_data_reg_snprintf(char *buf, size_t size,
 		default:
 			break;
 		}
+		break;
 	case DATA_VERDICT:
 	case DATA_CHAIN:
 		switch(output_format) {
@@ -220,6 +221,7 @@ int nftnl_data_reg_snprintf(char *buf, size_t size,
 		default:
 			break;
 		}
+		break;
 	default:
 		break;
 	}