From: Tilghman Lesher <tilghman@meg.abyt.es>
Date: Fri, 17 Sep 2010 21:06:03 +0000 (+0000)
Subject: Blank columns should get set on reload, not ignored.
X-Git-Tag: 1.4.37-rc1~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41969111bd465f9336c6a88560e5f6b27ef5245a;p=thirdparty%2Fasterisk.git

Blank columns should get set on reload, not ignored.

(closes issue #16893)
 Reported by: haakon
 Patches:
       20100818__issue16893.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@287386 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_queue.c b/apps/app_queue.c
index b0eb0217be..c7231672ed 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -1300,10 +1300,10 @@ static struct call_queue *find_queue_by_name_rt(const char *queuename, struct as
 		} else
 			tmp_name = v->name;
 
-		if (!ast_strlen_zero(v->value)) {
-			/* Don't want to try to set the option if the value is empty */
-			queue_set_param(q, tmp_name, v->value, -1, 0);
-		}
+		/* NULL values don't get returned from realtime; blank values should
+		 * still get set.  If someone doesn't want a value to be set, they
+		 * should set the realtime column to NULL, not blank. */
+		queue_set_param(q, tmp_name, v->value, -1, 0);
 	}
 
 	if (q->strategy == QUEUE_STRATEGY_ROUNDROBIN)