From: Fabiano Rosas <farosas@suse.de>
Date: Fri, 23 Jan 2026 14:16:31 +0000 (-0300)
Subject: migration: Remove redundant state change
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41982a06d1e600c49486d5a4e495ed77410848cf;p=thirdparty%2Fqemu.git

migration: Remove redundant state change

If local_err is set, migration_connect_error_propagate() will be
called and that function already has a state transition from SETUP to
FAILED.

Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-2-farosas@suse.de
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---

diff --git a/migration/migration.c b/migration/migration.c
index 4062c12d33..b46e01b8c0 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2323,8 +2323,6 @@ static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested,
         file_start_outgoing_migration(s, &addr->u.file, &local_err);
     } else {
         error_setg(&local_err, "uri is not a valid migration protocol");
-        migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
-                          MIGRATION_STATUS_FAILED);
     }
 
     if (local_err) {