From: Erik Skultety Date: Thu, 8 Sep 2016 13:28:07 +0000 (+0200) Subject: tests: fix incorrect status handling by virsh-self-test X-Git-Tag: v2.3.0-rc1~164 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=419bc8cf65ff38d9074224b3539696ee7d17d3d4;p=thirdparty%2Flibvirt.git tests: fix incorrect status handling by virsh-self-test The virsh-self-test script compared the test's return code with 1 and only if the return code matched this value then the test was marked as failed. Problem is that SIGSEGV returns 139 (or 11 to be precise, since shell reserves the MSB for abnormal exit signaling) which passes the check just fine and test then appears as successful which it most certainly wasn't. Therefore, flip the logic to compare against 0 instead and every other result will be treated as a failed test case. Signed-off-by: Erik Skultety --- diff --git a/tests/virsh-self-test b/tests/virsh-self-test index c51fcf46f5..641810f05f 100755 --- a/tests/virsh-self-test +++ b/tests/virsh-self-test @@ -28,7 +28,7 @@ $abs_top_builddir/tools/virsh -c $test_url self-test > /dev/null status=$? test_result 1 "virsh-self-test" $status -if test "$status" = "1" ; then +if test "$status" != "0" ; then fail=1 fi