From: Ryan Bloom Date: Thu, 7 Mar 2002 05:02:53 +0000 (+0000) Subject: There is no reason to insert the protocol filters in the insert_filters X-Git-Tag: CHANGES~216 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41a7e56b09bb82966d5a3014ab42fe404448e2d8;p=thirdparty%2Fapache%2Fhttpd.git There is no reason to insert the protocol filters in the insert_filters phase. This moves us to inserting the filters in the create_request phase. This makes more sense, because now the protocol filters are attached to the request as soon as possible. Previously, some requests never called the insert_filters phase, so they don't get the filters. Think redirects for reqeusts that never call insert_filters. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93750 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/modules/http/http_core.c b/modules/http/http_core.c index fcd7029e099..2d0ed64501f 100644 --- a/modules/http/http_core.c +++ b/modules/http/http_core.c @@ -302,7 +302,7 @@ static int ap_process_http_connection(conn_rec *c) return OK; } -static void ap_http_insert_filter(request_rec *r) +static void http_create_request(request_rec *r) { if (!r->main && !r->prev) { ap_add_output_filter_handle(ap_byterange_filter_handle, @@ -321,7 +321,7 @@ static void register_hooks(apr_pool_t *p) ap_hook_map_to_storage(ap_send_http_trace,NULL,NULL,APR_HOOK_MIDDLE); ap_hook_http_method(http_method,NULL,NULL,APR_HOOK_REALLY_LAST); ap_hook_default_port(http_port,NULL,NULL,APR_HOOK_REALLY_LAST); - ap_hook_insert_filter(ap_http_insert_filter, NULL, NULL, APR_HOOK_REALLY_LAST); + ap_hook_create_request(http_create_request, NULL, NULL, APR_HOOK_REALLY_LAST); ap_http_input_filter_handle = ap_register_input_filter("HTTP_IN", ap_http_filter, AP_FTYPE_HTTP_HEADER);