From: Victor Julien <vjulien@oisf.net>
Date: Wed, 25 May 2022 13:01:15 +0000 (+0200)
Subject: detect/parse: cleanup test
X-Git-Tag: suricata-7.0.0-beta1~547
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41b5364511776eeb39bf4ad9bf82766aff6d1629;p=thirdparty%2Fsuricata.git

detect/parse: cleanup test
---

diff --git a/src/detect-parse.c b/src/detect-parse.c
index 01070462e2..b1b1e7cb8f 100644
--- a/src/detect-parse.c
+++ b/src/detect-parse.c
@@ -3907,26 +3907,14 @@ end:
  */
 static int SigParseTestNegation07 (void)
 {
-    int result = 0;
-    DetectEngineCtx *de_ctx;
-    Signature *s=NULL;
-
-    de_ctx = DetectEngineCtxInit();
-    if (de_ctx == NULL)
-        goto end;
+    DetectEngineCtx *de_ctx = DetectEngineCtxInit();
+    FAIL_IF_NULL(de_ctx);
     de_ctx->flags |= DE_QUIET;
-
-    s = SigInit(de_ctx,"alert tcp any any -> [192.168.0.2,!192.168.0.0/24] any (msg:\"SigTest41-06 dst ip [192.168.0.2,!192.168.0.0/24] \"; classtype:misc-activity; sid:410006; rev:1;)");
-    if (s != NULL) {
-        SigFree(de_ctx, s);
-        goto end;
-    }
-
-    result = 1;
-end:
-    if (de_ctx != NULL)
-        DetectEngineCtxFree(de_ctx);
-    return result;
+    Signature *s = DetectEngineAppendSig(
+            de_ctx, "alert tcp any any -> [192.168.0.2,!192.168.0.0/24] any (sid:410006;)");
+    FAIL_IF_NOT_NULL(s);
+    DetectEngineCtxFree(de_ctx);
+    PASS;
 }
 
 /**