From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 30 Dec 2024 09:09:32 +0000 (+0000)
Subject: We only need -1 as an error indicator (CID #1604605)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41ba346b0561d541bd6c4db0080cb3529ae9dada;p=thirdparty%2Ffreeradius-server.git

We only need -1 as an error indicator (CID #1604605)
---

diff --git a/src/listen/ldap_sync/proto_ldap_sync.c b/src/listen/ldap_sync/proto_ldap_sync.c
index 95272446306..dfe9ae5938e 100644
--- a/src/listen/ldap_sync/proto_ldap_sync.c
+++ b/src/listen/ldap_sync/proto_ldap_sync.c
@@ -135,7 +135,7 @@ static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *
 	 */
 	ret = fr_internal_decode_list_dbuff(request->pair_list.request, &request->request_pairs,
 					   fr_dict_root(request->dict), &dbuff, NULL);
-	if (ret < 0) return ret;
+	if (ret < 0) return -1;
 
 	vp = fr_pair_find_by_da(&request->request_pairs, NULL, attr_packet_type);
 	fr_assert(vp);