From: Shravan Rangarajuvenkata (shrarang) <shrarang@cisco.com>
Date: Fri, 1 Nov 2019 17:26:43 +0000 (-0400)
Subject: Merge pull request #1831 in SNORT/snort3 from ~SATHIRKA/snort3:dns_compression_ptr... 
X-Git-Tag: 3.0.0-264~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41cd2cf96fcb4d280834a1e5749b1df58dd96d9c;p=thirdparty%2Fsnort3.git

Merge pull request #1831 in SNORT/snort3 from ~SATHIRKA/snort3:dns_compression_ptr to master

Squashed commit of the following:

commit 575eea2d85c85fa31aa73ff86d77c3ce85bd54ea
Author: Sreeja Athirkandathil Narayanan <sathirka@cisco.com>
Date:   Thu Oct 31 17:53:36 2019 -0400

    appid: Handle DNS responses with compression pointers at last record
---

diff --git a/src/network_inspectors/appid/detector_plugins/detector_dns.cc b/src/network_inspectors/appid/detector_plugins/detector_dns.cc
index f73a26c5d..7d59e8826 100644
--- a/src/network_inspectors/appid/detector_plugins/detector_dns.cc
+++ b/src/network_inspectors/appid/detector_plugins/detector_dns.cc
@@ -338,7 +338,7 @@ APPID_STATUS_CODE DnsValidator::dns_validate_label(const uint8_t* data, uint16_t
             len_valid = false;
             lbl_ptr = (const DNSLabelPtr*)lbl;
             offset += offsetof(DNSLabelPtr, data);
-            if (offset >= size)
+            if (offset > size)
                 return APPID_NOMATCH;
             tmp = (uint16_t)(ntohs(lbl_ptr->position) & 0x3FFF);
             if (tmp > size - offsetof(DNSLabel, name))