From: Jim Meyering <jim@meyering.net>
Date: Sun, 13 Oct 1996 17:58:50 +0000 (+0000)
Subject: (__xstrtol): Return an error for invalid suffix.
X-Git-Tag: TEXTUTILS-1_19n~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41dfaf296ad129c3f2d55e9b54158e49d6d35b6f;p=thirdparty%2Fcoreutils.git

(__xstrtol): Return an error for invalid suffix.
Before, e.g., `split -b 1M' would be silently accepted and treated
like `split -b 1'.  Reported by Franc,ois.
---

diff --git a/lib/xstrtol.c b/lib/xstrtol.c
index 8755cf475d..dec0ec79be 100644
--- a/lib/xstrtol.c
+++ b/lib/xstrtol.c
@@ -102,8 +102,11 @@ __xstrtol (s, ptr, base, val, valid_suffixes)
 	return LONGINT_INVALID_SUFFIX_CHAR;
     }
 
-  if (**p != '\0' && strchr (valid_suffixes, **p))
+  if (**p != '\0')
     {
+      if (!strchr (valid_suffixes, **p))
+	return LONGINT_INVALID_SUFFIX_CHAR;
+
       switch (**p)
 	{
 	case 'b':