From: Mike Bayer Date: Fri, 21 Dec 2018 19:13:41 +0000 (-0500) Subject: add pull request template X-Git-Tag: rel_1_3_0b2~59 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41f47fb72c5e9382b92f1c66f54771788be648ad;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git add pull request template Change-Id: I850c246e4f0feb62dca083909e5d010ce8288a3d --- diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..dbcda30447 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,11 @@ +*** **S T O P ! ! !** *** + +**TL;DR: don't submit a one liner "fix" for a code bug, show us your use case. We will fix it.** + +Is this pull request fixing a bug in the code and not just a typo in the documentation? If so, does your pull request include a **TEST CASE** ? Or have you filed a proper bug report that includes a **TEST CASE** ? + +*** **WE DO NOT ACCEPT ONE-LINER CODE-FIX PULL REQUESTS WITH NO TESTS.** *** The SQLAlchemy project does **NOT** merge bug fixes that aren't verified through tests, since such unverified code **IS A BUG**. If you would like us to write the tests, that is fine, please **FILE A BUG REPORT** which includes a **TEST SCRIPT**. + +The vast majority of "drive by" pull requests are incorrect solutions to an ill-defined problem. Please don't assume that the one line that fixed your problem is the actual fix, **NO MATTER HOW TRIVIAL**. And above all **HAVE A NICE DAY!!** + +